Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workaround permission issue on Android API30 emulators when pulling test results #64744

Merged
merged 1 commit into from
Feb 3, 2022

Conversation

akoeplinger
Copy link
Member

See dotnet/xharness#385, we use the cache dir instead on API 30.

Also add a:exported="true" which is required when targetting a newer minSdkVersion.

…est results

See dotnet/xharness#385, we use the cache dir instead on API 30.

Also add `a:exported="true"` which is required when targetting a newer minSdkVersion.
@ghost
Copy link

ghost commented Feb 3, 2022

Tagging subscribers to this area: @directhex
See info in area-owners.md if you want to be subscribed.

Issue Details

See dotnet/xharness#385, we use the cache dir instead on API 30.

Also add a:exported="true" which is required when targetting a newer minSdkVersion.

Author: akoeplinger
Assignees: -
Labels:

area-Infrastructure-mono

Milestone: -

@akoeplinger akoeplinger requested a review from premun February 3, 2022 14:52
public static int initialize(String entryPointLibName, String[] args, Context context) {
String filesDir = context.getFilesDir().getAbsolutePath();
String cacheDir = context.getCacheDir().getAbsolutePath();
String docsDir = getDocsDir(context);

File docsPath = context.getExternalFilesDir(Environment.DIRECTORY_DOCUMENTS);
Copy link
Member

@premun premun Feb 3, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the value of Environment.DIRECTORY_DOCUMENTS?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am asking because before we were setting env var DOCSDIR and I don't understand whether this is the same?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You mean the enum value? It's the string Documents.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, so it's something from Android

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah it's unrelated to the env var we set.

@akoeplinger akoeplinger merged commit d075b1f into dotnet:main Feb 3, 2022
@akoeplinger akoeplinger deleted the android-30 branch February 3, 2022 18:17
akoeplinger added a commit to akoeplinger/runtime that referenced this pull request Feb 7, 2022
In dotnet#64744 I changed the name of the env variable used to store the test results directoy but I didn't notice that the runtime tests don't use the same runner.

Fixes dotnet#64920
elinor-fung pushed a commit that referenced this pull request Feb 8, 2022
In #64744 I changed the name of the env variable used to store the test results directoy but I didn't notice that the runtime tests don't use the same runner.

Fixes #64920
@ghost ghost locked as resolved and limited conversation to collaborators Mar 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants